[Magiclysm] Add a way to craft everburning candle#86224
Merged
Maleclypse merged 15 commits intoCleverRaven:masterfrom Apr 6, 2026
Merged
[Magiclysm] Add a way to craft everburning candle#86224Maleclypse merged 15 commits intoCleverRaven:masterfrom
Maleclypse merged 15 commits intoCleverRaven:masterfrom
Conversation
…whitelist aenor_farm.*, since they are part of the same overmap special and the tests are failing?
…ense to whitelist aenor_farm.*, since they are part of the same overmap special and the tests are failing?" This reverts commit f8b4831.
Contributor
|
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
599c114 to
6945d58
Compare
Maleclypse
reviewed
Apr 3, 2026
Maleclypse
reviewed
Apr 4, 2026
Maleclypse
reviewed
Apr 5, 2026
Maleclypse
reviewed
Apr 5, 2026
Maleclypse
reviewed
Apr 5, 2026
Co-authored-by: Maleclypse <54345792+Maleclypse@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content "An elaborate and inconvenient way to craft everburning candles"
Purpose of change
Adds a way to craft everburning candles, using careful preparation, a new book and a new loot dropping from a Balrog.
Describe the solution
Added new items:
Added death_drop to fiery nightmare so it spawns a fading embers (active) on death.
Describe alternatives you've considered
This should be fine(ish), but I made it into a separate PR from the candles because I expect more feedback and discussion as it is less straightforward than simply "added candle variant of torch". 😄
Testing
Additional context
Crafting times might be wack. Maleclypse said it should be fine to have a recipe for crafting everburning items if it's less convenient than buying them from Valzain.