Skip to content

[Magiclysm] Add a way to craft everburning candle#86224

Merged
Maleclypse merged 15 commits intoCleverRaven:masterfrom
Michael1993:everburning-candle-craftable
Apr 6, 2026
Merged

[Magiclysm] Add a way to craft everburning candle#86224
Maleclypse merged 15 commits intoCleverRaven:masterfrom
Michael1993:everburning-candle-craftable

Conversation

@Michael1993
Copy link
Copy Markdown
Contributor

@Michael1993 Michael1993 commented Apr 3, 2026

Summary

Content "An elaborate and inconvenient way to craft everburning candles"

Purpose of change

Adds a way to craft everburning candles, using careful preparation, a new book and a new loot dropping from a Balrog.

Describe the solution

Added new items:

  • fading embers (active item, changes to wood ash after 20 minutes).
  • 0.5 L enchanted glass jar (mana infused glass jar for preserving alchemy materials)
  • sealed fading embers (jar + fading embers = preserved embers!)
  • Harnessing Hellfire (new book containing candle and ember sealing recipes)

Added death_drop to fiery nightmare so it spawns a fading embers (active) on death.

Describe alternatives you've considered

This should be fine(ish), but I made it into a separate PR from the candles because I expect more feedback and discussion as it is less straightforward than simply "added candle variant of torch". 😄

Testing

  • Teleported to Forge of Wonders. Ardelia now has "Harnessing Hellfire" in stock.
  • Spawned a fiery nightmare and debug killed it. It spawned a fading embers (active).
  • Waited 20 minutes. fading embers turned into wood ash.
  • Debug raised player skills for crafting candle/jar/etc.
  • Spawned necessary components/tools for infusing a jar and crafted enchanted jar.
  • Spawned fiery nightmare and debug killed it (again). Used the spawning fading embers to craft sealed fading embers.
  • Spawned necessary components/tools and crafted everburning candle. Worked like a charm.

Additional context

Crafting times might be wack. Maleclypse said it should be fine to have a recipe for crafting everburning items if it's less convenient than buying them from Valzain.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Mods: Magiclysm Anything to do with the Magiclysm mod labels Apr 3, 2026
@github-actions github-actions bot requested a review from KorGgenT April 3, 2026 14:10
…whitelist aenor_farm.*, since they are part of the same overmap special and the tests are failing?
…ense to whitelist aenor_farm.*, since they are part of the same overmap special and the tests are failing?"

This reverts commit f8b4831.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • "fading emberss"

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Michael1993 Michael1993 force-pushed the everburning-candle-craftable branch from 599c114 to 6945d58 Compare April 3, 2026 14:10
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Apr 3, 2026
Comment thread data/mods/Magiclysm/items/alchemy_items.json Outdated
Comment thread data/mods/Magiclysm/monsters/monsters.json Outdated
Comment thread data/mods/Magiclysm/items/recipe_books.json Outdated
Comment thread data/mods/Magiclysm/items/alchemy_items.json Outdated
Comment thread data/mods/Magiclysm/items/alchemy_items.json Outdated
Co-authored-by: Maleclypse <54345792+Maleclypse@users.noreply.github.com>
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 5, 2026
@Maleclypse Maleclypse merged commit eeef43b into CleverRaven:master Apr 6, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants