Removed evaluation column from term management page#567
Draft
Jonimz wants to merge 1 commit intodevelopmentfrom
Draft
Removed evaluation column from term management page#567Jonimz wants to merge 1 commit intodevelopmentfrom
Jonimz wants to merge 1 commit intodevelopmentfrom
Conversation
JohnCox2211
requested changes
Mar 17, 2026
Contributor
JohnCox2211
left a comment
JohnCox2211
left a comment
There was a problem hiding this comment.
The column for the midyear and final evaluations is gone, but connected code of the backend is still there. I don't think we use it anywhere else, so it should be removed too it seems in files like termManagement.py, term.py, studentLaborEvaluations.py, studentLaborEvaluations.html.
All of those files have references to variables used by this functionality like isFinalEvaluationOpen or isMidyearEvaluationOpen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #522
Changes:
Removed the Evaluations (Midyear | Final) column from the Term Management table as it is no longer needed. This includes the column header and the corresponding table cell containing the midyear and final evaluation toggle buttons for each term row.
Testing: