feat(dispatcher): enforce identity-safe lane GC - #523
Draft
zxkane wants to merge 2 commits into
Draft
Conversation
There was a problem hiding this comment.
This PR adds critical safety improvements to the garbage collector, implementing durable process identity verification and comprehensive backend checks across all kill authorization sites. The changes follow proper fail-safe patterns (fail toward preserving processes rather than incorrectly killing them).
Key improvements verified:
- Guardian identity verification in rule 1.4 (prevents signaling recycled PIDs)
- Durable process identity checks added throughout Pass 2/3
- Backend verification guards (ensures only pgid-backend lanes are subject to delayed signals)
- Platform-aware mode selection with config file rollback mechanism
- Comprehensive identity verification before all kill operations
The implementation is defensive and thorough, with no blocking defects identified. All safety guards properly handle edge cases and TOCTOU race conditions.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
zxkane
force-pushed
the
feat/lane-gc-p8-enforcement
branch
from
August 5, 2026 08:25
dc54cfa to
70cae74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Summary
elapsed_mson date implementations that ignore%3N, and allow the shared/user-scope installer to onboard and heal existing projects without project-local skills.Test Plan
docs/designs/lane-gc-p8-enforcement.md)docs/test-cases/lane-gc-p8-enforcement.md)origin/maingit diff --checkpassedOperator checkpoint (2026-08-27)
maindry-run was stopped after exceeding 48 hours without completing; its last complete summary was 2026-08-25.ADT_GC_ENFORCE=0(mode0600). The timer now runs this PR candidate in dry-run mode.adt-gc.sh --doctorpasses; the active backend is the sufficient PGID fallback.lane_mint/lane_installwiring.would_kill_legacy_signature=0,unknown_class=0,killed=0; focused P8 tests remain 120/120 green.The PR remains draft and production rollout is not authorized.