Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a Remote SSH workspace outside a recognized home layout, such as
/data/alice/project, session discovery can construct/.codex/sessions. An invalid configured path can also cause discovery to fall back to unrelated local sessions. Directory and session read errors are currently swallowed, making missing completion notifications difficult to diagnose.Require an explicit absolute remote
remoteSessionsPathwhen the home cannot be inferred, and keep remote workspaces from silently switching to local monitoring. Add bounded, throttled metadata diagnostics for remote directory/stat/read failures and deduplication, format diagnostic arrays and objects as JSON, and report OS notification submission status. On Windows, make toast submission failures observable and bound the helper execution to 10 seconds.Diagnostic records exclude transcript and notification bodies. They contain paths and session identifiers, so users should redact them before sharing.
submittedmeans the OS call succeeded, not that Windows displayed a banner.Validation:
task_completeevents, alongside filtered guardian metadata.Explicit paths retain priority; no machine-specific directory is hardcoded. This PR is independent of the optional foreground-notification feature.