style: drivers: use Kconfig glob for sourcing all sub-Kconfig #100607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josuah
force-pushed
the
kconfig_glob
branch
4 times, most recently
from
e695623 to
8b7d30a
Compare
josuah
added
Trivial
zephyrbot
requested review from
JordanYates,
KozhinovAlexander,
MaureenHelm,
asemjonovs,
avisconti,
casparfriedrich,
cvinayak,
danieldegrasse,
jeppenodgaard,
mniestroj,
ozersa,
teburd,
tristan-google,
ubieda and
yperess
Contributor
Author
|
Manual ping to the audio collaborators: the Kconfig in audio were renamed to allow a glob to happen:
|
Complement zephyrproject-rtos#99761 that added register includes to too few files. Fix build error for some boards using these SoCs. Signed-off-by: Josuah Demangeon <[email protected]>
added 2 commits
December 6, 2025 18:23
In order to use glob, add a common prefix to all audio codecs Kconfig files: "Kconfig.*" -> "Kconfig.codec_*". Reduce the effort in introducing new drivers and reduce ambiguity of which type of audio driver it is. Signed-off-by: Josuah Demangeon <[email protected]>
Simplify the contributin of new drivers by using the glob mechanism supported by Kconfig. This was already used by I2S Kconfig and is propagated to other driver classes. Signed-off-by: Josuah Demangeon <[email protected]>
|
henrikbrixandersen
requested changes
Dec 6, 2025
Member
henrikbrixandersen
left a comment
henrikbrixandersen
left a comment
There was a problem hiding this comment.
Please don't. This will source intermediate editor files, editor backup files etc, and break the development environment for a lot of end users.
Contributor
Author
|
There is more to Zephyr than just what's in-tree that is true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency:
It seems to work well for I2S:
zephyr/drivers/i2s/Kconfig
Line 28 in 8053d77
I have not unified all drivers to either absolute (
source) or relative (rsource), but can do it easily in the process.It removes one manual step for each contribution.
Current PRs that add a Kconfig entry might need to remove their
Kconfigaddition.