Skip to content

uwb: SR250 module files added - #790

Open
achinmaya-nxp wants to merge 1 commit into
zephyrproject-rtos:masterfrom
nxp-upstream:uwb-nxp-sr250-driver
Open

achinmaya-nxp wants to merge 1 commit into
zephyrproject-rtos:masterfrom
nxp-upstream:uwb-nxp-sr250-driver

Conversation

@achinmaya-nxp

Copy link
Copy Markdown

Changes to add NXP SR250 UWB driver support on zephyr
Note: This pull request has a dependency on #112599

Changes in this PR

  • Added proprietary SR250 files
  • Extended module.yml with entry for SR250 FW

Comment thread mcux/middleware/uwb/AppConfigParams.c Outdated
@@ -0,0 +1,173 @@
/* Copyright 2021-2022, 2026 NXP
*
* SPDX-License-Identifier: Apache-2.0

ghost Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should all files should use this Copyright?

ghost Aug 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is updated now

@@ -0,0 +1,31 @@
# Copyright 2026 NXP

ghost Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is there no change needed to the CMake file inside mcux/middleware folder to pull in this subsystem?

ghost Aug 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,37 @@
/*
*
* Copyright 2018-2020,2022 NXP.

ghost Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused with these copyright years. Where are these coming from? Also should 2026 be part of this?

ghost Aug 18, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mmahadevan108, copyright years mentioned indicate the years in which the file was modified. For this file, it was created/modified in 2018, 2019, 2020, 2022

@mmahadevan108

ghost commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

@axelnxp , can you share your review comments based on your experience with hal_nxp middleware.

@mmahadevan108

ghost commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

@zejiang0jason @iuliana-prodan , please review

ghost Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add an entry to the mcux README to indicate where this is coming from, take example on the other middlewares
modules/hal/nxp/mcux/README

BTW, is this folder located at the correct place? I can't find any uwb repo in the mcuxsdk manifest, which makes me think this is not a mcux-integrated repo.
Usually, middlewares that are integrated in the mcuxsdk should be put under mcux-sdk-ng/middlewares and reuse the same cmake from the mcuxsdk integration (you can check other middlewares as example), but this code doesn't seem to come from the mcuxsdk, please correct me if I'm wrong.
If this is not coming from the mcuxsdk, not sure it should be put under mcux.

ghost Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axelnxp, mcux is the default folder for all MCU parts which is what this middleware is targeted for.

ghost Sep 4, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README is updated with reference to UWB code on github

@mmahadevan108

ghost commented Aug 21, 2026 •

Copy link
Copy Markdown
Collaborator

@achinmaya-nxp can you take a look at the comment from @axelnxp regarding readme

uwb: SR250 module files added

Added proprietary SR250 files
Extended module.yml with entry for SR250 FW
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants