Repository navigation
uwb: SR250 module files added - #790
achinmaya-nxp wants to merge 1 commit into
Conversation
| @@ -0,0 +1,173 @@ | |||
| /* Copyright 2021-2022, 2026 NXP | |||
| * | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
Question: Should all files should use this Copyright?
| @@ -0,0 +1,31 @@ | |||
| # Copyright 2026 NXP | |||
There was a problem hiding this comment.
Question: Is there no change needed to the CMake file inside mcux/middleware folder to pull in this subsystem?
There was a problem hiding this comment.
Hi @mmahadevan108 UWB middleware code is enabled from zephyr/modules/hal_nxp/uwb/CMakeLists.txt
See https://github.com/zephyrproject-rtos/zephyr/pull/115786/changes#diff-7cb5c4c135d53f8a7611c8865b1046b323f29bfc4b1449a4e6012848916c8dcc
7c9c562 to
3634f47
Compare
| @@ -0,0 +1,37 @@ | |||
| /* | |||
| * | |||
| * Copyright 2018-2020,2022 NXP. | |||
There was a problem hiding this comment.
I am confused with these copyright years. Where are these coming from? Also should 2026 be part of this?
There was a problem hiding this comment.
Hi @mmahadevan108, copyright years mentioned indicate the years in which the file was modified. For this file, it was created/modified in 2018, 2019, 2020, 2022
commented
Aug 18, 2026
|
@axelnxp , can you share your review comments based on your experience with hal_nxp middleware. |
commented
Aug 18, 2026
|
@zejiang0jason @iuliana-prodan , please review |
There was a problem hiding this comment.
You need to add an entry to the mcux README to indicate where this is coming from, take example on the other middlewares
modules/hal/nxp/mcux/README
BTW, is this folder located at the correct place? I can't find any uwb repo in the mcuxsdk manifest, which makes me think this is not a mcux-integrated repo.
Usually, middlewares that are integrated in the mcuxsdk should be put under mcux-sdk-ng/middlewares and reuse the same cmake from the mcuxsdk integration (you can check other middlewares as example), but this code doesn't seem to come from the mcuxsdk, please correct me if I'm wrong.
If this is not coming from the mcuxsdk, not sure it should be put under mcux.
There was a problem hiding this comment.
@axelnxp, mcux is the default folder for all MCU parts which is what this middleware is targeted for.
There was a problem hiding this comment.
README is updated with reference to UWB code on github
|
@achinmaya-nxp can you take a look at the comment from @axelnxp regarding readme |
3634f47 to
6f4c18e
Compare
Changes to add NXP SR250 UWB driver support on zephyr
Note: This pull request has a dependency on #112599
Changes in this PR