feat: bump min php to 8.3 - #13
Merged
Merged
Conversation
The shared php-test workflow pins its own 8.2-8.5 matrix, so the test job is defined here to drop the 8.2 legs.
macOS reports its temp directory unresolved but creates files in the resolved one, so neither side matches the literal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops PHP 8.0-8.2 and the
symfony/polyfill-php81dependency, whose only use wasarray_is_list(). The sharedphp-test.ymlhardcodes an 8.2-8.5 matrix and takes no version input, so the test job is inline here with the same composite action.Second commit is housekeeping:
dirname($file) === '/tmp'is only true on Linux, so nine assertions have failed on macOS since the initial commit. They now go through anassertInTempDir()helper.