fix: nested join aliases, add a Spec::between() factory - #59
Merged
Merged
Conversation
A nested join defaulted its alias to the relation name, so joining relations with the same name on different parents failed with "'x' is already defined". Nested aliases are now prefixed with their parent's, and an anti-join returns its expression so it composes correctly inside `orX()`.
`Util::stringify()` returned the `Stringable` itself from a method declared `: string` - it only worked because this package doesn't declare strict types.
`Between` was the only filter you had to construct directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three unrelated issues found in the audit, one commit each.
Join::inner('relation')->scope(Join::inner('entities')->scope(Join::inner('relation')))failed with[Semantical Error] ... 'relation' is already defined. Nested aliases are now prefixed with their parent's (relation_entities,relation_entities_relation); an explicit alias is never touched. While in there, an anti-join now returns its expression instead of callingandWhere()itself, so it composes correctly insideorX()- previously it was applied unconditionally.Util::stringify()returned aStringablefrom a method declared: string. Harmless today only because this package doesn't declare strict types.Spec::between(), soBetweenis no longer the only filter you have to construct directly. README updated.