Skip to content

Drop our Playwright CookieJar once playwright-symfony provides one #201

Description

@kbond

src/Browser/Session/Playwright/CookieJar.php proxies ->use(CookieJar $jar) to the real browser, because the client's own jar held a copy and mutating it had no effect.

playwright-php/playwright-symfony#52 moves that upstream: getCookieJar() returns a jar backed by the browser context. Once it lands and we require a version with it, this class and tests/Session/Playwright/CookieJarTest.php can go, about 190 lines, and PlaywrightBrowser no longer needs the cookieJar() override.

Already verified: dropping the override and letting getCookieJar() through keeps can_manipulate_cookies and the remember-me test green.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions