fixes in setup.py for emscripten-wasm32 build#737
Draft
DerThorsten wants to merge 6 commits intozarr-developers:mainfrom
Draft
fixes in setup.py for emscripten-wasm32 build#737DerThorsten wants to merge 6 commits intozarr-developers:mainfrom
DerThorsten wants to merge 6 commits intozarr-developers:mainfrom
Conversation
7 tasks
Contributor
|
See also: #529, which is also a contemporary PR that performs a subset of the changes here. I'm not fully sure how |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are needed to build the package with emscripten.
This PR disables / bypasses the usage of the
cpuinfopackage when building for emscripten-wasm32.Furthermore I removed the threading argument from blosc when compiling for emscripten.
TODO: