Skip to content

Conversation

@devlopergalxboy
Copy link
Contributor

@devlopergalxboy devlopergalxboy commented Feb 10, 2026

What this PR does / why we need it

Summary of this PR
Implements namespace injection in all Helm templates using .Release.Namespace to ensure resources are deployed in the intended namespace.
Related Issues
(If applicable, reference issues in the format: closes #123)
Additional Information for Reviewers
Please let me know if further changes or clarifications are needed.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Upgrading instructions are documented in the zammad/README.md

@mgruner mgruner requested a review from monotek February 10, 2026 10:58
@mgruner
Copy link
Collaborator

mgruner commented Feb 10, 2026

@devlopergalxboy thanks for the PR! Could you please let us know what exact problem it solves? AFAICT it's already possible to install Zammad into namespaces via helm --namespace.

@devlopergalxboy
Copy link
Contributor Author

@devlopergalxboy thanks for the PR! Could you please let us know what exact problem it solves? AFAICT it's already possible to install Zammad into namespaces via helm --namespace.

@mgruner when we tried to deploy using rendered manifest pattern we identified that most of our resources were not being injected with the correct namespace which left us out of sync on our ArgoCD as such we thought it would be a great idea that who ever wants to use zammad with the rendered manifest pattern they can do so without having issues of namespace injection.

Yes adding the flag --namespace to the command works well.

@mgruner
Copy link
Collaborator

mgruner commented Feb 10, 2026

@monotek do you agree to this change?

Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly the reason I don't like ArgoCD.
I just won't work without changes to the resources it should just manage 🙄

FluxCD FTW! ;-)

But in the end the change does no harm.

@mgruner mgruner merged commit d44cd14 into zammad:main Feb 10, 2026
8 checks passed
@mgruner
Copy link
Collaborator

mgruner commented Feb 10, 2026

Thank you @devlopergalxboy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants