chore: sync swift localization from platform-localization#165
Closed
platform-localization-pr-bot[bot] wants to merge 1 commit into
Closed
chore: sync swift localization from platform-localization#165platform-localization-pr-bot[bot] wants to merge 1 commit into
platform-localization-pr-bot[bot] wants to merge 1 commit into
Conversation
Contributor
✅ Commit Lint: passedAll commit messages in this PR conform to Conventional Commits. 📦 Release preview:
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
1336
to
1339
| "signIn.appMessage": { | ||
| "extractionState": "manual" | ||
| "extractionState": "manual", | ||
| "comment": "" | ||
| }, |
Contributor
There was a problem hiding this comment.
signIn.appMessage received an empty string (""). An empty comment gives translators no context about where or how this string is used, which is particularly important here since the key has no localized value yet. It would be great to fill this in with a short description of what the app message is for.
Suggested change
| "signIn.appMessage": { | |
| "extractionState": "manual" | |
| "extractionState": "manual", | |
| "comment": "" | |
| }, | |
| "signIn.appMessage": { | |
| "extractionState": "manual", | |
| "comment": "App-specific message shown on the sign-in screen." | |
| }, |
Prompt To Fix With AI
This is a comment left during a code review.
Path: Sources/YouVersionPlatformUI/Resources/Localizable.xcstrings
Line: 1336-1339
Comment:
Every other string entry in this file has a descriptive translator comment, but `signIn.appMessage` received an empty string (`""`). An empty comment gives translators no context about where or how this string is used, which is particularly important here since the key has no localized value yet. It would be great to fill this in with a short description of what the app message is for.
```suggestion
"signIn.appMessage": {
"extractionState": "manual",
"comment": "App-specific message shown on the sign-in screen."
},
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Contributor
Code Coverage ReportCoverage after merging chore/localization-sync-swift-20260629-4fa6992 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
|
Closing this one as there will be a new push coming soon to clean up the comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated localization sync from
platform-localization.4fa6992cc909a1115d57ce53d4f0af76ef230692Distribute Swift LocalizationGreptile Summary
This automated PR syncs localization data from
platform-localization, adding descriptivecommentfields to all existing string entries inLocalizable.xcstringsand introducing two new string keys (bibleVersionsHeadingandbooksHeading). The comments provide clear translator context across the ~50 string entries, which is a great improvement.bibleVersionsHeading,booksHeading) are added with English-only translations; French/German/Spanish localizations are expected in a future sync.signIn.appMessagereceives an emptycommentfield (""), diverging from every other entry which has a descriptive comment.Confidence Score: 4/5
Safe to merge — the change is entirely additive, touching only translator comments and two new English-only string keys.
The sync correctly adds descriptive comments to all ~50 existing keys and introduces two new string entries. The only wrinkle is signIn.appMessage receiving an empty comment where a descriptive one was expected, leaving translators without context for that key.
Sources/YouVersionPlatformUI/Resources/Localizable.xcstrings — specifically the empty comment on signIn.appMessage.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[platform-localization repo\nsource ref: 4fa6992c] -->|Distribute Swift Localization workflow| B[Automated PR Bot] B -->|writes| C[Localizable.xcstrings] C -->|string keys + comments| D[Xcode String Catalog] D -->|en| E[English ✅] D -->|fr| F[French ✅ existing\n⚠️ missing for new keys] D -->|de| G[German ✅ existing\n⚠️ missing for new keys] D -->|es-MX| H[Spanish ✅ existing\n⚠️ missing for new keys] E & F & G & H --> I[SwiftUI / UIKit\nLocalized string lookups]%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A[platform-localization repo\nsource ref: 4fa6992c] -->|Distribute Swift Localization workflow| B[Automated PR Bot] B -->|writes| C[Localizable.xcstrings] C -->|string keys + comments| D[Xcode String Catalog] D -->|en| E[English ✅] D -->|fr| F[French ✅ existing\n⚠️ missing for new keys] D -->|de| G[German ✅ existing\n⚠️ missing for new keys] D -->|es-MX| H[Spanish ✅ existing\n⚠️ missing for new keys] E & F & G & H --> I[SwiftUI / UIKit\nLocalized string lookups]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore: sync swift localization" | Re-trigger Greptile