fix(ci): revert mcp-go 0.54.0 bump that raised go.mod to 1.25.5 - #281
Merged
Merged
Conversation
yoanbernabeu
added a commit
that referenced
this pull request
Aug 30, 2026
The test matrix ran Go 1.22 and 1.23 while go.mod already required 1.24.2, and lint/build pinned 1.22. Those jobs only passed because Go silently downloads the required toolchain -- so the matrix was not testing the versions it claimed, and a go.mod bump could break CI in ways the matrix could not catch. That is exactly what happened with mcp-go 0.54.0 (#242, reverted in #281): raising the directive to 1.25.5 broke lint ("go1.24 is lower than the targeted 1.25.5") and every test job ("go: no such tool covdata"). Test matrix moves to 1.24/1.25, lint and build to 1.25. The coverage upload condition follows the matrix (1.22 -> 1.24), otherwise it would never fire. This also unblocks the pending dependency bumps that require Go 1.25: qdrant/go-client (#253), pgvector-go (#254) and pgx/v5 (#228). Claude-Session: https://claude.ai/code/session_01HYsWPWwoCnaitbmMx71U5z Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainhas been red since 63a42a4 (#242, mcp-go 0.45.0 → 0.54.0). That bump raised thegodirective ingo.modfrom1.24.2to1.25.5, which breaks every CI job:Lint:
Test (all 6 matrix jobs): every package with test files passes, but packages without them fail to build their coverage profile, and the job exits 1:
The CI matrix installs Go 1.22 and 1.23. With
go 1.25.5ingo.mod, the build switches to a downloaded toolchain whilecovdatais still resolved against the local GOROOT, and the mismatch surfaces asno such tool.Confirmed by the run history on
main:0de6e1263a42a4The later merges are not at fault — they only inherited a red
main.Fix
Revert #242, restoring
go 1.24.2and mcp-go 0.45.0 — the last known-green state.Follow-up
mcp-go 0.54.0 requires Go 1.25, so taking it means dropping Go 1.22/1.23 from the support matrix. That is a product decision, not a dependency bump, and it needs its own PR touching
.github/workflows/ci.yml(test matrix + the Go version used for lint and build). Dependabot will re-open the bump; it should stay blocked until that decision is made.