Skip to content

Updates to address gnome extensions review - #152

Open
toolstack wants to merge 1 commit into
yilozt:mainfrom
toolstack:review-fixes
Open

toolstack wants to merge 1 commit into
yilozt:mainfrom
toolstack:review-fixes

Conversation

@toolstack

@toolstack toolstack commented Feb 10, 2024 •

Copy link
Copy Markdown

Should resolve #145

@AlexNabokikh

Copy link
Copy Markdown

@yilozt would you be so kind to review and approve this change?

@Hyperspeed1313

Copy link
Copy Markdown

Does this change not also need to be made to src/prefs.ts? I don't know much about extensions but it looks to be the same file in both locations. Is the version at src/prefs.ts for Gnome 44 and below?

@toolstack

Copy link
Copy Markdown
Author

Does this change not also need to be made to src/prefs.ts? I don't know much about extensions but it looks to be the same file in both locations. Is the version at src/prefs.ts for Gnome 44 and below?

This change is to src/prefs.ts so I'm not sure what your referring to here.

@Hyperspeed1313

Copy link
Copy Markdown

I'm not sure anymore either.

@toolstack

Copy link
Copy Markdown
Author

I don't think it matters anymore as it looks like the extension is dead 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish onto extensions.gnome.org?

3 participants