Repository navigation
Conversation
vjik
commented
Oct 16, 2026
vjik
commented
Member
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Also drop the Yii2-style timestamp format with underscore and fix misleading examples of unqualified class name and timestamp.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #373 +/- ##
============================================
+ Coverage 97.48% 97.52% +0.04%
- Complexity 395 402 +7
============================================
Files 30 30
Lines 1232 1254 +22
============================================
+ Hits 1201 1223 +22
Misses 31 31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vjik
changed the title
migrate:mark: add --all option, preview history changes, drop Yii2-style versionsmigrate:mark: add --clear option, preview history changes, drop Yii2-style versions
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues; implementation, tests, and documentation are consistent, though tests were not executed.
0 open findings
What changed in this PR
Updates migrate:mark to make history-only changes clearer and easier to preview.
Changes:
- Replaces the special base version with
--clearand removes Yii2-style timestamps. - Lists affected migrations before confirmation.
- Updates tests, documentation, and changelog.
| File | Description |
|---|---|
| tests/Driver/Sqlite/MarkCommandTest.php | Uses --clear in rollback coverage. |
| tests/Common/Command/AbstractMarkCommandTest.php | Tests previews, clearing, confirmation, and argument validation. |
| tests/Common/Command/AbstractDatabaseCommandsTest.php | Updates database-isolated clearing coverage. |
| src/Command/MarkCommand.php | Adds --clear, previews, and revised version validation. |
| docs/guide/en/migration-history.md | Documents the updated command interface. |
| CHANGELOG.md | Updates PR references and contributor credits. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.