Nox/ UI page - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces basic client-side routing and initial UI/page scaffolding in the Electron renderer, along with several shared UI components and new UI-related dependencies.
Changes:
- Wrapped the renderer in
HashRouterand added route definitions + navigation inApp.jsx. - Added initial pages (
Home,Dashboard,NotFound) to support the new routes. - Added multiple UI components (card/dialog/input/label/table/toaster) and updated dependencies; also stopped auto-opening DevTools.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| elelectron/src/renderer.jsx | Wraps the React app with HashRouter to enable routing in the renderer. |
| elelectron/src/App.jsx | Adds navigation and Routes for Home/Dashboard/NotFound. |
| elelectron/src/pages/home.jsx | Introduces the Home page component. |
| elelectron/src/pages/dashboard.jsx | Introduces the Dashboard page component. |
| elelectron/src/pages/notfound.jsx | Introduces a NotFound fallback route component. |
| elelectron/src/main.js | Stops auto-opening DevTools (but leaves an outdated comment). |
| elelectron/src/components/ui/table.jsx | Adds reusable table primitives. |
| elelectron/src/components/ui/sonner.jsx | Adds a Toaster wrapper (currently depends on next-themes). |
| elelectron/src/components/ui/label.jsx | Adds a reusable label component. |
| elelectron/src/components/ui/input.jsx | Adds a reusable input component using Base UI. |
| elelectron/src/components/ui/dialog.jsx | Adds dialog primitives/wrappers. |
| elelectron/src/components/ui/card.jsx | Adds reusable card primitives. |
| elelectron/package.json | Adds routing + theming/toast dependencies. |
| elelectron/package-lock.json | Locks new dependencies (includes Node engine constraints). |
Files not reviewed (1)
- elelectron/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
27
to
28
| // Open the DevTools. | ||
| mainWindow.webContents.openDevTools(); | ||
| }; |
Comment on lines
+44
to
+49
| "next-themes": "^0.4.6", | ||
| "react": "^19.2.8", | ||
| "react-dom": "^19.2.8", | ||
| "react-router-dom": "^7.18.2", | ||
| "shadcn": "^4.18.0", | ||
| "sonner": "^2.0.8", |
Comment on lines
+13
to
+17
| <nav className="flex gap-2 p-4"> | ||
| <Button onClick={() => navigate("/")}>Home</Button> | ||
| <Button variant="outline" onClick={() => navigate("/dashboard")}> | ||
| Dashboard | ||
| </Button> |
Comment on lines
+1
to
+9
| import { useTheme } from "next-themes" | ||
| import { Toaster as Sonner } from "sonner"; | ||
| import { CircleCheckIcon, InfoIcon, TriangleAlertIcon, OctagonXIcon, Loader2Icon } from "lucide-react" | ||
|
|
||
| const Toaster = ({ | ||
| ...props | ||
| }) => { | ||
| const { theme = "system" } = useTheme() | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.