Refactor TEvPut ctors, return relevance trackers for request actors #30621
Conversation
|
⚪ |
|
⚪ |
Run Extra TestsRun additional tests for this PR. You can customize:
|
|
🟢 |
There was a problem hiding this comment.
Pull request overview
This PR refactors the TEvBlobStorage::TEvPut constructor API to use a named parameters pattern via a new TParameters struct, while maintaining backward compatibility through delegating constructors. The unsafe constructor with many positional parameters (including externalRelevanceWatcher) has been removed in favor of the more explicit TParameters approach.
- Introduced
TParametersstruct with named fields for safer and more readable constructor calls - Refactored existing convenience constructors to delegate to the TParameters-based constructor
- Updated test code to demonstrate the new usage pattern with named parameters
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ydb/core/base/blobstorage.h | Added TParameters struct and refactored TEvPut constructors to use it, removing the unsafe constructor with positional parameters |
| ydb/core/blobstorage/ut_blobstorage/cancellation.cpp | Updated test to use the new TParameters constructor with named arguments for better clarity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
serbel324
changed the title
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
BackportTo backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.
|
3 participants
Changelog entry
Add ctor with named args for TEvPut, remove unsafe ctor, add internal relevance watcher alongside external one
Changelog category