Avoid recursive-delete approval for literal rm filenames - #1481
Open
SamuelChien wants to merge 1 commit into
Open
SamuelChien wants to merge 1 commit into
SamuelChien wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-file cleanup such as
rm -f controls/evidence/valid-rec-grand-meridian-dev-a-drained/answer.jsonincorrectly requests recursive-delete approval because the policy regex reads-rinside an operand. A bounded argument check now clears that existing match only for provably non-recursive literal commands, honoring command boundaries and--.The serialized rule, matched text, approval key, ordering and scope/layer precedence remain unchanged. Expansions, redirections, unsupported shell invocations and uncertain wrappers retain the existing gate. Shared shell parsing and heredoc behavior are unchanged.
Validation: 137 affected policy, route, layer, broker, session and scratch tests pass on Node 24; full TypeScript and changed-file ESLint pass. Independent security and compatibility reviews passed, including 630 wrapper/quoting combinations against baseline decision, matched text and approval identity. No live endpoint is needed for this pure policy change.