Repository navigation
fix(demo): stop scene blocks from overlapping in the video - #1
Merged
Merged
Conversation
Five scenes held more content than a 1080-line frame. The stage grid is centred and may shrink, so the extra height lay across the headline above it and the alert below it. The layout check only compared elements with the frame edges, so it reported all ten scenes as good. The check now also fails when stage content is taller than its row and when two blocks cover the same pixels. The scenes are reduced until all ten pass: shorter lists and captions, one-line headlines, and the tool calls in two columns. The title tagline has clearance from the wordmark. The outro no longer shows the AWS line. The narration and its timing are not changed. The video is rendered again at the same length, 4:41.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check_scene_layout.mjsonly compared elements with the frame edges, so it reported all ten scenes as good. It now also fails when stage content is taller than its row and when two blocks cover the same pixels.Test Plan
npm run typecheckindemo/videowright