fix: keep Archive script inside the HTML document - #1
Draft
y4ho0 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
BaseLayout, so Astro emits it before</body>instead of after</html>.</html>tags and non-whitespace content after the closing document element.Why
The browser recovered from the malformed output and the empty Archive page appeared functional, but the production build placed its page script after the closing
</html>tag. This is invalid document structure and was not covered by the existing output checks.Impact
Archive behavior is unchanged. The generated page is now structurally valid, and future instances of trailing content after
</html>will fail the build.Validation
npm run checknpm test(10 passed)npm run buildgit diff --check</html>/archive/renders without overflow or console errors