feat(web): new UI (partially implemented)#4933
Conversation
maoyuehui
commented
May 21, 2026
- Framework: Next.js, UI: @radix-ui
- Global: i18n, request, theme, app-init, constants, hooks, etc.
- Pages: login, cluster-information, register-model (partial)
|
To clarify, tech stack used is aligned with Xagent, and will not be default until version 3.0 |
There was a problem hiding this comment.
Code Review
This pull request establishes the foundation for the inference service's frontend, implementing a Next.js application with comprehensive UI components, internationalization, and modules for cluster management and model registration. The review identifies several critical issues, including a hardcoded internal IP address, a potential XSS vulnerability in the multi-select component, and incorrect usage of the next/image component. Additionally, improvements are suggested for server-side fetch performance, polling patterns in the cluster dashboard, and Tailwind CSS configuration for markdown rendering.
|
/gemini review |
1 similar comment
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request establishes the frontend foundation for Xinference using Next.js 15, implementing model registration, cluster monitoring, and internationalization. The code review identified several technical issues, including a bug where clearInterval was incorrectly used to clear a setTimeout and potential failures in server-side data fetching due to relative URLs. Recommendations were also provided to improve the reliability of polling mechanisms, remove duplicate utility functions, sanitize string interpolation logic, and eliminate leftover debug code.
There was a problem hiding this comment.
Code Review
This pull request initializes the frontend for the Xinference project using Next.js 15 and React 19, featuring a robust UI component library, multi-language support (i18n), and pages for cluster monitoring and model registration. Feedback highlights several areas for improvement, including fixing a timer cleanup bug where clearInterval was used instead of clearTimeout, addressing a hardcoded locale in date formatting, and preventing potential URL concatenation errors. Additionally, recommendations were made to correct a dependency version for lucide-react, remove leftover debugging code, optimize images using the next/image component, and enhance error messaging and TypeScript typing for better maintainability.
qinxuye
left a comment
There was a problem hiding this comment.
I found two current build blockers that are not covered by the existing review threads. Also, git diff --check upstream/main...HEAD currently fails due to trailing whitespace in several frontend files, so please run the formatter or clear those whitespace errors as well.