Skip to content

feat(i18n): update Japanese and Korean locale translations#4932

Merged
qinxuye merged 2 commits into
mainfrom
feat/i18n-ja-ko-locales
May 21, 2026
Merged

feat(i18n): update Japanese and Korean locale translations#4932
qinxuye merged 2 commits into
mainfrom
feat/i18n-ja-ko-locales

Conversation

@m199369309
Copy link
Copy Markdown
Collaborator

@m199369309 m199369309 commented May 20, 2026

Summary

  • Updated ja.json and ko.json with comprehensive translations for new UI features
  • Covers user management, API key management, and other recently added components

Test plan

  • Verify Japanese locale renders correctly in browser
  • Verify Korean locale renders correctly in browser
  • Check no missing translation keys compared to en.json

Add comprehensive translations for new UI features including user management,
API key management, and other recently added components.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@XprobeBot XprobeBot added this to the v2.x milestone May 20, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds translation strings for user management, API key management, authentication, and permissions to the Japanese and Korean locale files. The review feedback highlights the need to include these new keys in the base English and Chinese locales for consistency, to ensure the new menu items are correctly integrated into the UI navigation, and to maintain a consistent camelCase naming convention for the permission keys.

Comment thread xinference/ui/web/ui/src/locales/ja.json Outdated
Comment thread xinference/ui/web/ui/src/locales/ja.json Outdated
Comment thread xinference/ui/web/ui/src/locales/ja.json
Copy link
Copy Markdown
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the locale updates and added one non-duplicate issue.

Comment thread xinference/ui/web/ui/src/locales/ja.json Outdated
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 8fb5cec into main May 21, 2026
10 of 13 checks passed
@qinxuye qinxuye deleted the feat/i18n-ja-ko-locales branch May 21, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants