[Preflight] Do not report custom enums as unsupported types#1005
Merged
Conversation
kvch
force-pushed
the
fix-check-enum-types
branch
from
July 16, 2026 15:14
552ebd5 to
d51fef6
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
tsg
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously,
pgstream checkflagged every user-defined enum column as an unsupported type, e.g.:This is a false positive. The check only recognizes types that pgx 's static type map knows by OID, and enum OIDs are database-specific, so enums never resolve. But the Postgres target replicates enum values as text (with the enum type itself replicated via
CREATE TYPE), so they migrate fine.SchemaTypeCompatibilityChecknow skips enum columns. This covers both scalar enums (typtype = 'e') and arrays of enums (typtype = 'b') whose element carries the enum kind.Type of Change
Please select the relevant option(s):
Testing
Checklist