Ignore per-session temp schemas in inferred migrations#1027
Open
JoeyEamigh wants to merge 1 commit into
Open
Conversation
exekias
approved these changes
May 26, 2026
exekias
left a comment
exekias
left a comment
Member
There was a problem hiding this comment.
Thank you for contributing! this change makes sense to me, WDYT @andrew-farries ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pg_roll_handle_ddlevent trigger inpkg/state/init.sqlrecords an inferred row inpgroll.migrationsfor any DDL that happens outside a pgroll-owned connection. It filters pgroll's own sessions viapgroll.no_inferred_migrations, but it doesn't exclude PostgreSQL temp schemas.I have been running pgroll in prod for ~2 months and have 291 inferred rows on
pg_tempschemas. It's not harmful by any stretch, but is messy.This PR adds a name-prefix guard in
placeholder.raw_migration()that filters temp tables and a test.