Update grpc-netty-shaded, grpc-protobuf, ... to 1.78.0#4118
Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the project's gRPC dependencies to their latest stable version, 1.78.0. This update ensures the project benefits from the most recent features, performance improvements, and bug fixes provided by the gRPC library, contributing to better stability and compatibility. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, generated by Scala Steward, updates gRPC dependencies from version 1.77.0 to 1.78.0. The change is straightforward and correct. My review includes a recommendation to plan an upgrade for the related protobuf-java dependency, as the currently used major version series is now end-of-life, which could pose future maintenance and security risks.
| val FINAGLE_VERSION = "24.2.0" | ||
| val FLUENCY_VERSION = "2.7.3" | ||
| val GRPC_VERSION = "1.77.0" | ||
| val GRPC_VERSION = "1.78.0" |
There was a problem hiding this comment.
While updating the gRPC version is good, it's worth noting that the gRPC-java 1.78.0 release notes state that the 3.x series of protobuf-java is now end-of-life (EOL). The gRPC team strongly recommends migrating to the 4.x series (e.g., 4.26.1).
Your project currently uses protobuf-java version 3.25.8 in the benchmark module. To ensure you are using a supported version and to avoid potential future security vulnerabilities or compatibility issues, it would be beneficial to plan a migration to protobuf-java 4.x in a separate pull request.
About this PR
📦 Updates
from
1.77.0to1.78.0📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: