Skip to content

Fix #434: REST client default timeouts #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
banterCZ wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix #434: REST client default timeouts #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc7dc6f
Fix #434: REST client default timeouts
banterCZ Feb 18, 2026
c856ef6
update documentation
banterCZ Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,9 @@ The following options are available for the builder:
- `username` - proxy username
- `password` - proxy password
- `connectionTimeout` - connection timeout in milliseconds (default: 5000 ms)
- `responseTimeout` - Maximum duration allowed between each network-level read operations. (default: no timeout)
- `maxIdleTime` - ConnectionProvider max idle time. (default: no max idle time)
- `maxLifeTime` - ConnectionProvider max life time. (default: no max life time)
- `responseTimeout` - Maximum duration allowed between each network-level read operations. (default: 60s)
- `maxIdleTime` - ConnectionProvider max idle time. (default: 200s)
- `maxLifeTime` - ConnectionProvider max life time. (default: 1h)
- `keepAliveEnabled` - Keep-Alive probe feature flag (default: false)
- `keepAliveIdle` - Keep-Alive idle time
- `keepAliveInterval` - Keep-Alive retransmission interval time
Expand Down
6 changes: 3 additions & 3 deletions rest-client-base/src/main/java/com/wultra/core/rest/client/base/RestClientConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ public class RestClientConfiguration {

// HTTP connection timeout
private Duration connectionTimeout = Duration.ofMillis(5000);
private Duration responseTimeout;
private Duration responseTimeout = Duration.ofSeconds(60);

private Duration maxIdleTime;
private Duration maxLifeTime;
private Duration maxIdleTime = Duration.ofSeconds(200);
private Duration maxLifeTime = Duration.ofHours(1);
Comment on lines +54 to +57
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces new default behavior (timeouts and connection pool maxIdleTime/maxLifeTime) but there is no test asserting these defaults when the user does not explicitly configure them. Consider adding/adjusting tests to verify the default durations are applied (and that they can still be disabled when set to null via the builder), to prevent accidental regressions.

Copilot uses AI. Check for mistakes.
Copy link

@michal-rozehnal-w michal-rozehnal-w Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should have test for the default values


private boolean keepAliveEnabled;
private Duration keepAliveIdle;
Expand Down