Extract WebBridge to be reused in SwiftUI.WebView#177
Draft
crazytonyli wants to merge 1 commit intotrunkfrom
Draft
Extract WebBridge to be reused in SwiftUI.WebView#177crazytonyli wants to merge 1 commit intotrunkfrom
crazytonyli wants to merge 1 commit intotrunkfrom
Conversation
crazytonyli
force-pushed
the
extract-web-bridge
branch
from
c26c5cd to
eb2fdba
Compare
crazytonyli
force-pushed
the
extract-web-bridge
branch
from
eb2fdba to
b16a0fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick prototype of creating a SwiftUI version of
EditorViewController, using the newSwiftUI.WebViewAPI in iOS 26. See the newGutenbergEditorSwiftUI view.The idea is to extract the code that interacts with the Gutenberg library web view out of
EditorViewController, which then can be reused by theGutenbergEditorSwiftUI view.WebBridgeis the beginning of that.At the moment,
WebBridgeonly contains code that configures the Gutenberg editor library. Later, we can add more API to execute JavaScript functions within the web view.You can try the new SwiftUI view via the demo app, by turning on the "Use SwiftUI WebView" toggle.
Potential next steps
I don't think we need to have a SwiftUI view at the moment, but I think it's worthwhile extracting some Gutenberg editor specific code out of the
EditorViewController, which would put the library into a good position to create a SwiftUI view when needed.So, I guess that could be the next steps? Moving some more code out of
EditorViewController?