Open
Conversation
Squashed commit of the following:
commit 63b0fc7f808428c8bbe0c1817b55ff0175a99820
Author: conatuseus <conatuseus@gmail.com>
Date: Tue Aug 6 22:10:40 2019 +0900
dependency 수정
Book 도메인 생성
Squashed commit of the following:
commit 40a5f9b7ccbb6e7cd1ba0d7d1da4da6b3223d8bf
Author: conatuseus <conatuseus@gmail.com>
Date: Tue Aug 6 22:14:24 2019 +0900
create Book
BookRepository 생성
Squashed commit of the following:
commit 84804929be5d4de6bc8c3d599c5a783f869c112d
Author: conatuseus <conatuseus@gmail.com>
Date: Tue Aug 6 22:17:43 2019 +0900
create Book repository
isbn을 unique column으로 변경
Squashed commit of the following:
commit 2ca85c79a692838343aad0a5f3680ae16db11192
Author: conatuseus <conatuseus@gmail.com>
Date: Tue Aug 6 22:23:17 2019 +0900
fix isbn to unique
Squashed commit of the following:
commit a9a351a8030b906b5e8930be9ef513aad3033d45
Author: conatuseus <conatuseus@gmail.com>
Date: Fri Aug 9 17:33:29 2019 +0900
id로 book 검색 기능 구현
Squashed commit of the following:
commit 891c9a4d15a37b8cc1c4d45a5089aac7db38c3af
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 16:48:53 2019 +0900
Book create 서비스 메서드 구현
commit a962d5ec3264e72fa3272844b1922dcd710b3516
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 16:48:29 2019 +0900
Builder annotation 삭제, 생성자 구현
commit c18f57ad9ca66dc75970916f6b59498a5955bd76
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 16:47:29 2019 +0900
BookCreateResponseDto 구현
commit e16d3cdee691bf8eed559de87159a9bd6c469924
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 16:47:11 2019 +0900
BookCreateRequestDto 구현
commit 5a74e72b19739e016ecfe8161ad626a043cc403a
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 16:46:44 2019 +0900
Book create 메소드 구현
book의 id로 삭제하는 로직 구현
code formatting
Squashed commit of the following:
commit f4c4e92e2692753fee7ac8fce1e846cd6ba7827b
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 20:18:54 2019 +0900
deleteBook 메서드 구현
commit d5fe6f9fe16e9d309f86a19bee6e6945c62f836d
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 20:18:24 2019 +0900
code 정리
commit 6139a39523b9d24a4e308f3442223c1c556da457
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 20:18:10 2019 +0900
BookDeleteResponseDto 구현
commit b6d10ba16484308d19c926caa941c44c8c50821d
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 20:17:30 2019 +0900
코드 정리
commit d5bd9a82495fe1aedd64326244b60e5312fd8a58
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 20:17:17 2019 +0900
코드 정리
commit 5719d29c6660538c87a447ab08cd1c5400ea7872
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 20:17:04 2019 +0900
code 정리
commit a325bf90bd28518064e414d0728a1246961b05d6
Author: conatuseus <conatuseus@gmail.com>
Date: Sun Aug 11 20:16:37 2019 +0900
book delete method 구현
Squashed commit of the following:
commit 2b2971dc1a49874ec4e1a8fe7060f3ff0d9f3f1b
Author: conatuseus <conatuseus@gmail.com>
Date: Mon Aug 12 21:24:52 2019 +0900
findBooksByKeyword 메서드 구현
commit f78636ef61f20b576a824a30449c190bb67f78b8
Author: conatuseus <conatuseus@gmail.com>
Date: Mon Aug 12 21:24:18 2019 +0900
keyword로 책 찾는 requestDto 구현
commit 3dee202cec142ab5bd792aa3dbf1cf43f2a870ba
Author: conatuseus <conatuseus@gmail.com>
Date: Mon Aug 12 21:23:27 2019 +0900
keyword로 book 찾는 메서드 선언
commit 3b05625c5279bee3e51d82cd5272fd23926106bd
Author: conatuseus <conatuseus@gmail.com>
Date: Mon Aug 12 21:19:26 2019 +0900
title에 keyword 포함된 book 찾는 메서드 구현
commit 355ea1142badfcd0b6cb7e6b3e0769e4a2ed1551
Author: conatuseus <conatuseus@gmail.com>
Date: Mon Aug 12 21:18:34 2019 +0900
Exception message 구현
commit 2c47bcbb2eb67fde0b77841ff072023c1621731c
Author: conatuseus <conatuseus@gmail.com>
Date: Mon Aug 12 21:17:30 2019 +0900
title 키워드로 책 찾는 메서드 구현
Squashed commit of the following:
commit 296c44e326b4c0fc7ad1c7896490eb50926d9359
Author: conatuseus <conatuseus@gmail.com>
Date: Mon Aug 12 22:14:36 2019 +0900
ResponseEntity 반환하도록 변경
Squashed commit of the following:
commit 8e7cc0e6836b2b31dcb57cc677953c439edf4072
Author: conatuseus <conatuseus@gmail.com>
Date: Mon Aug 12 23:47:27 2019 +0900
page로 책 list 가져오는 메서드 구현
commit a33117d087df387c33bf00a39042a3b85643876a
Author: conatuseus <conatuseus@gmail.com>
Date: Mon Aug 12 23:46:58 2019 +0900
주석 제거
commit c8aa2b3bcfb807fa712716ae1833de5f2c518441
Author: conatuseus <conatuseus@gmail.com>
Date: Mon Aug 12 23:46:26 2019 +0900
불필요한 annotation 제거
commit 8c12e294d05d232980dc5f8a5dfbe83250361d28
Author: conatuseus <conatuseus@gmail.com>
Date: Mon Aug 12 23:46:05 2019 +0900
page별로 book list 가져오는 메서드 구현
MrKwon
suggested changes
Aug 13, 2019
|
|
||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| @Column(nullable = false, length = 11) |
| } | ||
|
|
||
| public List<BookInfoResponseDto> findBooksByKeyword(String keyword) { | ||
| List<Book> foundBooks = bookRepository.findBooksByTitleContains(keyword); |
| @@ -0,0 +1,48 @@ | |||
| package com.woowacourse.tecobrary.domain; | |||
Contributor
There was a problem hiding this comment.
domain package 안에 model package 를 생성한 후 Book 을 넣어주세요.
현재 file path 가
src/main/java/com/woowacourse/tecobrary/domain/Book.java
라면
다음과 같이 바꿔주세용
src/main/java/com/woowacourse/tecobrary/domain/model/Book.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postman으로 수동 테스트는 다 해봤는데, 테스트코드를 작성하지 않았네요.
테스트코드 빠른 시일 내에 추가할게요!
BookController 마지막 두 메서드의 url에 관련해서 고민되네요.
코치님에게 물어보고 url에 대한 피드백 반영하도록 할게요.