Skip to content

DMX Output support exclude message incorrectly displayed on builds *with* support#5353

Merged
netmindz merged 1 commit intowled:mainfrom
netmindz:dmx-output-enabled-error
Feb 6, 2026
Merged

DMX Output support exclude message incorrectly displayed on builds *with* support#5353
netmindz merged 1 commit intowled:mainfrom
netmindz:dmx-output-enabled-error

Conversation

@netmindz
Copy link
Member

@netmindz netmindz commented Feb 6, 2026

Builds display message saying no DMX output support for builds which do contain this feature

Summary by CodeRabbit

  • Refactor
    • Improved the display handling for DMX output settings in the Sync configuration page, ensuring proper visibility controls for the DMX output section.

@netmindz netmindz added this to the 0.15.4 milestone Feb 6, 2026
@netmindz netmindz added the bug label Feb 6, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Walkthrough

Function and DOM element renamed from "dmxOnOff2"/"hideNoDMX" to "dmxOnOffOutput"/"hideNoDMXOutput" in the SYNC settings page. Updated both the JavaScript function definition and its call site in the XML configuration.

Changes

Cohort / File(s) Summary
DMX Output Function Rename
wled00/data/settings_sync.htm, wled00/xml.cpp
Renamed JavaScript function from hideNoDMX() to hideNoDMXOutput() and updated the associated DOM container id from "dmxOnOff2" to "dmxOnOffOutput" to improve clarity regarding DMX output visibility handling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • softhack007
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the bug being fixed: a misleading message about DMX output support appearing on builds that actually have support.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netmindz netmindz merged commit 4d63b3c into wled:main Feb 6, 2026
24 checks passed
@netmindz netmindz removed this from the 0.15.4 milestone Feb 6, 2026
@netmindz netmindz deleted the dmx-output-enabled-error branch February 6, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant