backend: add nrfutil scraper backend - #64
Conversation
wkhadgar
left a comment
wkhadgar
left a comment
There was a problem hiding this comment.
Thanks for making your first great contrib here! This looks really nice, I see this has no tests added for the readers, could you add tests like the other scrapers do? You can see the style in tests/test_msgq_walker.py and tests/test_cli.py
Really appreciate the time and effort put to help this project, thanks again
Implement NrfutilScraper (using nrfutil cli) and register nrfutil as an available runner in the CLI. Unfortunatelly nrfutil is a stateless tool so every memory read requires spawning a fresh process. Signed-off-by: Flavio Ceolin <flavio.ceolin@gmail.com>
|
@wkhadgar sorry for the late reply, things have been pretty busy on my side :/ I hope I have addressed your comments. |
|
@ceolin regarding the unit tests, would you mind if this got merged right now without them, and I hooked up some for this new scrapper in a new PR, or would you rather add a follow up commit with some bare ones mimicking the already shipped ones? |
No problem on my side, please go ahead :) |
2 participants
Implement NrfutilScraper (using nrfutil cli) and register nrfutil as an available runner in the CLI. Unfortunatelly nrfutil is a stateless tool so every memory read requires spawning a fresh process.