feat: add iconBackground support to backButton on iOS and Android #8160
Conversation
|
@markdevocht, should I merge master already? |
There was a problem hiding this comment.
Hey thanks @adids1221!
Could you add a visual of some sort describing what you need?
Also, please be sure to add at least one visual (e2e) test to cover this use case 🙏🏻
@markdevocht @gosha212 let's discuss whether this is the right approach (=API) once we understand the use case better
|
@markdevocht thank you for the help! The issue solved by adding the if statment in |
markdevocht
left a comment
markdevocht
left a comment
There was a problem hiding this comment.
Also I saw @d4vidi left a comment in his review about finding another way of doing it.
ios/RNNIconDrawer.mm
Outdated
| UIImage *newImage = UIGraphicsGetImageFromCurrentImageContext(); | ||
| UIGraphicsEndImageContext(); | ||
|
|
||
| if (color && color != UIColor.clearColor) { |
There was a problem hiding this comment.
you can remove the color != UIColor.clearColor
| os: '15.5', | ||
| type: 'iPhone 16', | ||
| os: '18.2', | ||
| }, |
There was a problem hiding this comment.
This is your change? if so, make sure to update all the snapshots from the snapshot tests. BUT I don't think you should update this.
There was a problem hiding this comment.
Reverted to your config.
|
Verified on Android and IOS, added detox test. 
@d4vidi
|
|
#rebuild |
adids1221
dismissed
d4vidi’s stale review
As we spoke mark did the solution for IOS here, added a figma and e2e test.
Description
Adds
iconBackgroundsupport to backButton options, enabling circular/rounded backgrounds behind the back button icon - matching existing functionality for rightButtons and leftButtons.Changes:
Changelog
TopBar BackButton - Added iconBackground support with color, cornerRadius, width, and height properties.
Additional info
MADS-4884