fix(state): let the backend decide whether MessageState needs a state… - #409
Merged
Merged
Conversation
…_ttl PostgresBackend's retention is the pgmq archive's, so it ignores the ttl. Gating the middleware on that ttl forced its users to pass a value meaning nothing to record any state at all. StateBackend.requires_ttl carries the decision instead: true for the redis and stub backends, false for PostgresBackend.
mducros-wm
force-pushed
the
fix/state-backend-owns-ttl-gate
branch
from
September 2, 2026 15:54
1ad68b3 to
d11c649
Compare
fregogui
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgresBackend's retention is the pgmq archive's, so it ignores the ttl. Gating the middleware on that ttl forced its users to pass a value meaning nothing to record any state at all. StateBackend.requires_ttl carries the decision instead: true for the redis and stub backends, false for PostgresBackend.