feat(conversation): process welcome: retain key package on error [WPB-27413]#2366
Merged
SimonThormeyer merged 4 commits intoJul 24, 2026
Merged
Conversation
SimonThormeyer
changed the title
SimonThormeyer
marked this pull request as ready for review
July 23, 2026 13:21
SimonThormeyer
force-pushed
the
simon/feat/process-welcome-keep-keypackage-in-error-case
branch
2 times, most recently
from
July 23, 2026 13:29
72068ac to
d97d0e0
Compare
coriolinus
approved these changes
Jul 23, 2026
coriolinus
left a comment
coriolinus
left a comment
Contributor
There was a problem hiding this comment.
I like how you cleared four of the nits in the pending review with fixups before I even had the chance to post the review!
One more non-blocking nit. But good work!
SimonThormeyer
force-pushed
the
simon/feat/process-welcome-keep-keypackage-in-error-case
branch
4 times, most recently
from
July 24, 2026 09:01
a2ae6bd to
aa18653
Compare
coriolinus
force-pushed
the
prgn/refactor/23775-use-unified-connection
branch
2 times, most recently
from
July 24, 2026 10:21
2cb4498 to
f9f6893
Compare
SimonThormeyer
force-pushed
the
simon/feat/process-welcome-keep-keypackage-in-error-case
branch
from
July 24, 2026 11:21
aa18653 to
00cedfb
Compare
coriolinus
force-pushed
the
prgn/refactor/23775-use-unified-connection
branch
from
July 24, 2026 11:24
f9f6893 to
9c89c82
Compare
Base automatically changed from
prgn/refactor/23775-use-unified-connection
to
main
July 24, 2026 11:24
SimonThormeyer
force-pushed
the
simon/feat/process-welcome-keep-keypackage-in-error-case
branch
from
July 24, 2026 11:38
00cedfb to
2bafcac
Compare
SimonThormeyer
changed the title
SimonThormeyer
force-pushed
the
simon/feat/process-welcome-keep-keypackage-in-error-case
branch
from
July 24, 2026 12:03
2bafcac to
8e88116
Compare
SimonThormeyer
deleted the
simon/feat/process-welcome-keep-keypackage-in-error-case
branch
July 24, 2026 13:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for correctness, see corresponding item.
Unfortunately it's a bit more complex than expected, and we need a condition to hold for this to work: the keypackage must have been created in an earlier transaction. It's reasonable to assume that, though, imo