Open
Conversation
Owner
|
Thanks @feliperyan for the PR. With the latest release - v0.2.0 - we added file extension filtering, so I do not think that this is required any longer. What's your thoughts? |
Author
|
Hey @wintermi totally up to you mate, I'm not precious. The one obvious use case is if the user has a messy dir with mixed image types and wants to exclude some, or a dir tree where only certain folders need to be excluded. |
Owner
|
Agreed, there are benefits. The PR needs to be aligned with the restructuring made for v0.2.0. Also, rather than use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for a ignore file similar to
.gitignorein order for users to exclude unwanted files such as.DS_Storeetc.The file should be in the pwd and named
.ocrignore