Repository navigation
Conversation
…s during package install.
mcaskill
left a comment
There was a problem hiding this comment.
This condition was brought up during the refactor to support Composer 2 and bounced around a bit [1] [2].
| if ($this->state->forceUpdate()) { | ||
| // Force update mode so that new packages are processed rather | ||
| // than just telling the user that composer.json and | ||
| // composer.lock don't match. | ||
| $installer->setUpdate(true); | ||
| } else { | ||
| $this->logger->log('You may need to manually run composer update to apply merge settings'); | ||
| } |
There was a problem hiding this comment.
Inconsistent indentation:
| if ($this->state->forceUpdate()) { | |
| // Force update mode so that new packages are processed rather | |
| // than just telling the user that composer.json and | |
| // composer.lock don't match. | |
| $installer->setUpdate(true); | |
| } else { | |
| $this->logger->log('You may need to manually run composer update to apply merge settings'); | |
| } | |
| if ($this->state->forceUpdate()) { | |
| // Force update mode so that new packages are processed rather | |
| // than just telling the user that composer.json and | |
| // composer.lock don't match. | |
| $installer->setUpdate(true); | |
| } else { | |
| $this->logger->log('You may need to manually run composer update to apply merge settings'); | |
| } |
There was a problem hiding this comment.
This still needs fixing at least...
|
We have tested this in quite a few scenarios and it's correctly respecting the intended functionality. Maybe @reedy if you could have a look please? |
| if ($this->state->forceUpdate()) { | ||
| // Force update mode so that new packages are processed rather | ||
| // than just telling the user that composer.json and | ||
| // composer.lock don't match. | ||
| $installer->setUpdate(true); | ||
| } else { | ||
| $this->logger->log('You may need to manually run composer update to apply merge settings'); | ||
| } |
There was a problem hiding this comment.
This still needs fixing at least...
|
Hi @reedy thank you for your activity on this. Thank you! |
Respect composer lock, no update any packages during package install.