Reject zero PBKDF iterations without a positive time budget (GH #1366) - #1367
Open
Coralesoft wants to merge 1 commit into
Open
Reject zero PBKDF iterations without a positive time budget (GH #1366)#1367Coralesoft wants to merge 1 commit into
Coralesoft wants to merge 1 commit into
Conversation
…i11#1366) PBKDF1, PBKDF2, and the PKCS weidai11#12 KDF silently treated zero iterations as one when no positive time budget was supplied, guarded only by a debug assert. Throw `InvalidArgument` instead while preserving the timed mode where zero iterations are paired with a positive time budget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1366.
PBKDF1, PBKDF2, and the PKCS #12 KDF silently treated zero iterations as one when no positive time budget was supplied, guarded only by a debug assert that is inactive in release builds.
Throw
InvalidArgumentfor zero iterations without a positiveTimeInSeconds, including NaN. The existing timed mode, where zero iterations are paired with a positive time budget, is unchanged.