Use two-argument static_assert in CRYPTOPP_COMPILE_ASSERT - #1359
Open
Coralesoft wants to merge 1 commit into
Open
Use two-argument static_assert in CRYPTOPP_COMPILE_ASSERT#1359Coralesoft wants to merge 1 commit into
Coralesoft wants to merge 1 commit into
Conversation
CRYPTOPP_COMPILE_ASSERT expanded to static_assert(expr), which is a C++17 form. This can warn under -Wc++17-extensions when code is compiled as C++14. Use static_assert(expr, #expr) instead. The two-argument form is C++11 and works with the standards the library supports. The stringified expression is also useful in compile-error messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRYPTOPP_COMPILE_ASSERTexpanded tostatic_assert(expr), which is the single-argument C++17 form. This can warn under-Wc++17-extensionswhen code is compiled as C++14.Using
static_assert(expr, #expr)keeps the macro compatible with C++11 and C++14. The stringified expression also gives a useful message when the assert fails.What changed
CRYPTOPP_COMPILE_ASSERTinmisc.hto usestatic_assert(expr, #expr).