Repository navigation
Fix major version tag not being updated on release - #31
Merged
Merged
Conversation
The previous versioning workflow used Actions-R-Us/actions-tagger without an explicit permissions block. With GitHub's read-only default GITHUB_TOKEN it cannot push the major tag, so `v1` was never moved to v1.3.0. Replace it with the same script-based workflow used in wearerequired/lint-action: it declares `contents: write` and force-updates the `vMAJOR` tag to the released commit via git.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
v1tag still points to the v1.2.0-era commit and was never moved to v1.3.0. The current workflow usesActions-R-Us/actions-tagger@v2without apermissions:block, so with GitHub's read-only defaultGITHUB_TOKENit cannot push the updated major tag.Change
Replace it with the same script-based workflow used in
wearerequired/lint-action, which:permissions: contents: writeexplicitly, andvMAJORtag (e.g.v1) to the released commit viagit tag --force/git push --force.[[ … ]]is fine here since workflowrun:steps default tobash.Note
This only takes effect on the next release. After merging, publishing v1.3.1 should move
v1automatically. The currentv1can also be repointed manually once v1.3.1 is tagged: