main.py format#4
Open
ross-buc wants to merge 2 commits into
Open
Conversation
wasabi9
reviewed
May 19, 2023
| question = input("Enter you question; just press enter for ending the session: ") | ||
| if question.lower() == "": | ||
| break | ||
| print(docqa.answer_query(question)["choices"][0]["message"]["content"]) |
Owner
There was a problem hiding this comment.
this helps in better readability but is not necessarily needed. Since if statement always breaks out of the loop. Will merge anyways.
Owner
|
The changes look good and can be merged. But before that better if you create a branch in this same repo and create a pull request in this repo itself. It seems like you have forked the repo and made changes there. |
Contributor
Author
|
Okay thanks, I have created a new branch for the changes and submitted another pull request. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Wasabi,
I am currently studying Python programming, git and github. This is my first pull request, I hope the following changes made are helpful.
Thankyou