fix(weave): resolve recursive LiteralOperation schema to fix Mintlify warnings#6955
Open
rajkumar-prog wants to merge 1 commit into
Open
fix(weave): resolve recursive LiteralOperation schema to fix Mintlify warnings#6955rajkumar-prog wants to merge 1 commit into
rajkumar-prog wants to merge 1 commit into
Conversation
|
This PR requires manual approval from a wandb user to run all CI checks. To see the current diff, click here. To approve CI for this PR as of this commit, comment: |
Author
|
/approve be45200 |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=5c00326293e674804efc84c4aaf335a1bfc59c3e |
be45200 to
5416f1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #5619
The
LiteralOperationschema insdks/node/weave.openapi.jsoncontains recursive self-references:Static OpenAPI tooling (including Mintlify) cannot resolve infinite recursive schemas and emits warnings during documentation builds.
Root cause
LiteralOperationrepresents a JSON literal — a value that can be a string, number, boolean, object, array, or null. Objects and arrays within a literal can themselves contain arbitrary values, but the schema modelled this as a recursive reference toLiteralOperation. Static tools cannot follow infinite recursion, unlike a runtime parser.Fix
Replaced the recursive
$refentries with open schemas that are semantically equivalent for a JSON literal:"additionalProperties": true— object values are unconstrained"items": {}— array elements are unconstrainedThis matches the runtime behaviour (any JSON value is valid) while remaining resolvable by static tooling.
Changes
sdks/node/weave.openapi.json— 2 lines changed