fix(trace): return removed row from pop()#6901
Open
Dev-X25874 wants to merge 2 commits into
Open
Conversation
|
This PR requires manual approval from a wandb user to run all CI checks. To see the current diff, click here. To approve CI for this PR as of this commit, comment: |
Contributor
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=19f2000ed354292cb60a6e2bd6cb95459abec524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both
Table.pop()inweave/trace/table.pyandWeaveTable.pop()inweave/trace/vals.pywere declared-> Noneand discarded the returnvalue of the underlying
list.pop()call. Python'slist.pop()removesand returns the element at the given index; these implementations
silently broke that contract, meaning any caller doing:
would always receive
Noneinstead of the removed dict.Fix: capture and return the result of the inner
list.pop()in bothmethods, and update their return type annotations from
-> Noneto-> dict.Testing
Verified by code inspection that both call sites previously discarded
the
list.pop()return value. No existing tests coverTable.pop()orWeaveTable.pop()(confirmed via grep), so no tests were broken. Manualsmoke-test of the corrected behaviour: