[codex] Fix agent GenAI columns and chat refs#6899
Closed
bcsherma wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=b2c0c8fa3bb8c877bd5ea55a2fe7ad6e20d3b6cb |
ddfe87f to
d5bbe6f
Compare
d5bbe6f to
eb9a436
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes the Agent spans/query and chat surfaces for GenAI spans.
raw_span_dumpwhen explicitly requested.weave:///...refs are stored internally asweave-trace-internal:///...before ClickHouse insert.Root cause:
project_idandwb_user_id, but did not walk refs embedded inside protobufAnyValueattributes. Those external refs were stored directly in span fields such ascontent_refs. Later, the public response adapter correctly treated external refs in an internal response as invalid and raisedInvalidInternalRef, surfacing as a 500.Testing
uv run pytest tests/trace_server/test_trace_server_interface_util.py tests/trace_server/test_trace_server_converter.py tests/trace_server/query_builder/test_agent_query_builder.pycontent_refs/object_refsasweave-trace-internal:///...in local ClickHouse.tilt prod_weavetrace:/agents/traces/chatand/agents/conversations/chatreturned 200 for newly seededbcanfieldsherman/agents-lorem-ipsumrows.