Skip to content

fix(weave): replace stale version hint in object name validation error message#6888

Closed
rajkumar-prog wants to merge 2 commits into
wandb:masterfrom
rajkumar-prog:fix/stale-version-hint-error-message
Closed

fix(weave): replace stale version hint in object name validation error message#6888
rajkumar-prog wants to merge 2 commits into
wandb:masterfrom
rajkumar-prog:fix/stale-version-hint-error-message

Conversation

@rajkumar-prog
Copy link
Copy Markdown

Problem

Fixes #5771

The error message in weave/trace_server/validation.py tells users to upgrade to >0.51.0 to fix invalid object name errors:

Invalid object name: {name}. Contains invalid characters: {invalid_char_set}. Please upgrade your `weave` package to `>0.51.0` to prevent this error.

This is misleading because:

  • Weave is already at 0.52+, so users who see this are already on a newer version
  • Version-specific hints in error messages always become stale over time

Fix

Replaced the stale version hint with a clear, actionable message that tells users exactly what characters are allowed.

Before:

...Please upgrade your `weave` package to `>0.51.0` to prevent this error.

After:

...Object names must only contain alphanumeric characters, dashes, underscores, and periods.

Changes

  • weave/trace_server/validation.py — 1 line changed

@rajkumar-prog rajkumar-prog requested a review from a team as a code owner May 19, 2026 19:42
@rajkumar-prog
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@wandbot-3000
Copy link
Copy Markdown

wandbot-3000 Bot commented May 19, 2026

This PR requires manual approval from a wandb user to run all CI checks.

To see the current diff, click here.

To approve CI for this PR as of this commit, comment:

/approve e8176e31d3765980afaeb60a281393b2a6186cf0

@rajkumar-prog
Copy link
Copy Markdown
Author

/approve e8176e3

@rajkumar-prog
Copy link
Copy Markdown
Author

/approve e8176e3

@wandbot-3000
Copy link
Copy Markdown

wandbot-3000 Bot commented May 19, 2026

@rajkumar-prog
Copy link
Copy Markdown
Author

/approve e8176e3

1 similar comment
@rajkumar-prog
Copy link
Copy Markdown
Author

/approve e8176e3

@ro31337
Copy link
Copy Markdown
Contributor

ro31337 commented May 21, 2026

Hey @rajkumar-prog, thanks for picking this up. One note on the second commit: the sdks/node/weave.openapi.json change isn't mentioned in the PR description (which references #5771 — the validation-message fix). That file is also the input to yarn generate-api for the Node SDK TypeScript bindings, and removing the recursive $ref to LiteralOperation would weaken the generated types. Might be cleaner to split the openapi edit into its own PR.

@rajkumar-prog
Copy link
Copy Markdown
Author

Closing this in favour of a clean PR that contains only the validation message fix — the openapi.json change accidentally included here belongs to #6871. Reopening with a single-commit branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: weave > v0.52+ throws "please upgrade to >0.51"

2 participants