feat(telemetry): Telemetry for Seaweed#194
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sets MetricsPort on master/volume/filer in the Seaweed CR and replaces the broken `seaweedfs` VMPodScrape with three new ones that actually scrape the per-component metrics ports. Then swaps the leftover MinIO queries in the install + overview dashboards for `SeaweedFS_volumeServer_resource` (capacity) and `SeaweedFS_filer_request_total` (rate). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…erator The seaweedfs-operator tries to create `ServiceMonitor` resources during reconcile, but our cluster doesn't have that CRD installed (we use VictoriaMetrics, not prometheus-operator), so its reconciler errors after master and volume/filer never come up. Adds the prometheus-operator-crds chart dep with just the ServiceMonitor CRD enabled plus an RBAC binding for the operator's ServiceAccount — the VictoriaMetrics operator auto-converts those ServiceMonitors to VMServiceScrapes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jthakkar04
force-pushed
the
jthakkar/seaweed-telemetry
branch
from
27f027a to
66ac6f5
Compare
# Conflicts: # deploy/operator/Chart.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Issue
JIRA: https://coreweave.atlassian.net/browse/ONPREM-205
What this does
MetricsPorton the master/volume/filer specs in the Seaweed CR so each component actually starts a/metricsHTTP server.minio_*queries (SeaweedFS_volumeServer_resourcefor capacity andSeaweedFS_filer_request_totalfor the rate).prometheus-operator-crds v29.0.0as a chart dep with only the ServiceMonitor CRD enabled, plus an RBAC binding for the seaweedfs-operator's ServiceAccount. We had to add this because the seaweedfs-operator tries to create a ServiceMonitor for each Seaweed component during reconcile, and without the CRD installed it errors out before reaching volume/filer — so only the master pod ever comes up.Tests
Spun up the kind cluster:
./hack/scripts/setup_kind.sh ; tilt upSaw traffic on Dashboard:
