Merged
Conversation
Allows topological sort to also sort with respect to contextual lookup context sets.
Works correctly with And(...) and Or(...)
This extracts (according to the dependency graph) the full boolean conditions for each glyph in a font. Boolean conditions are represented in conjunctive normal form. Because this is dep graph based, may be a superset of the true subset closure conditions. Note: this implementation does not yet respect closure phases, that is planned to be added next.
garretrieger
force-pushed
the
true_conditions
branch
from
5201e47 to
9a6ffcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts (according to the dependency graph) the full boolean conditions for each glyph in a font. Boolean conditions are represented in conjunctive normal form. Because this is dep graph based, may be a superset of the true subset closure conditions.
High level algorithm:
The final boolean expressions are represented in conjunctive normal form in terms of segment presence (ActivationCondition). Unlike prior approaches which are limited to finding purely conjunctive/disjunctive expressions this can pull out arbitrary composite conditions.
This is not yet hooked up or used by anything, but should be able to replace the other dep graph based approaches to condition finding (DependencyClosure::AnalyzeSegment).
Note: this implementation does not yet respect closure phases, that is planned to be added next.