Remove SegmentInteractionGroup().#199
Merged
garretrieger merged 1 commit intow3c:mainfrom Apr 1, 2026
Merged
Conversation
What an interaction group is was poorly defined, SegmentsThatInteractWith() can be utilized instead which has a much more clear definition. SegmentsThatInteractWith() is extended to work with nodes instead of just glyphs, this allows SegmentationContext to replace it's usage of SegmentInteractionGroup(). Lastly, this also cleans up special casing around features which is no longer needed now that feature conjunction has edges present on both sides in the graph.
garretrieger
force-pushed
the
segment_interaction_group
branch
from
8fb3385 to
9de7630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What an interaction group is was poorly defined, SegmentsThatInteractWith() can be utilized instead which has a much more clear definition.
SegmentsThatInteractWith() is extended to work with nodes instead of just glyphs, this allows SegmentationContext to replace it's usage of SegmentInteractionGroup().
Lastly, this also cleans up special casing around features which is no longer needed now that feature conjunction has edges present on both sides in the graph.