Skip to content

feat(agent): design_loop revision assist + solid-only Adam path - #775

Merged
w1ne merged 2 commits into
developfrom
feat/design-loop-revision-assist
Sep 24, 2026
Merged

w1ne merged 2 commits into
developfrom
feat/design-loop-revision-assist

Conversation

@w1ne

@w1ne w1ne commented Sep 24, 2026

Copy link
Copy Markdown
Owner

Summary

Closes the next Adam+/ChatGPT tooling gaps after #774:

  1. Revision assist — failing design_loop attempts return structured revisionAssist (hints-only | suggested-patches | auto-applied-candidate) with AST patches from repair_script for boolean miss / oversized fillet / etc. Honest: not full autonomous CAD rewrite.
  2. Solid-only path — single-body housings that evaluate clean no longer fail solely because review_cad requires assembly().
  3. Toy fail-closed — assembly.quality.stacked-primitive-toy (+ missing fillet on housing prompts) for production/complex goals.
  4. Tooling fix — pose-envelope interference respects solvedModel({ ignore }) / dfmSpec.ignore.
  5. Cookbook — mechanism cheeks overlap beam (was 4 disconnected solids).

Smoke (local evaluate / design_loop)

See docs/agent/smoke/adam-chatgpt-gaps-smoke.json (Thu 2026-09-25 ~01:21 CEST):

Target evaluate design_loop
multi-feature-machined-housing ok (17 feats) ok (solid-only-evaluate)
multi-body-mechanism-real-proportions ok, mechanism: real still agent-dependent: joint-support / grounded-root / gravity-hold
stacked toy on production goal — fail-closed + cookbook hint
oversized fillet — autoApplied.suggestedCode → fillet(4)

open_in_studio / mesh CDN not re-exercised this slice (already live).

Test plan

  • unit: revisionAssist heuristics + auto-apply mock
  • unit: design_loop stacked-toy / solid-only / geometry facts / likeness / nextActionPrompt
  • unit: poseEnvelope ignoredPairs interference
  • public contract fixture
  • local smoke evidence checked in

Close next Adam+/ChatGPT gaps after #774:

- Structured revisionAssist on failing design_loop attempts (hints /
  suggestedPatches / autoApplied.suggestedCode via bounded repair_script)
- Solid-only path: single-body housings that evaluate clean pass functional
  without requiring assembly()
- Fail-closed stacked-primitive-toy + missing-fillet for production goals
- Pose-envelope interference now honours solvedModel ignore + dfmSpec.ignore
- Cookbook multi-body-mechanism: fix disconnected yoke/cheek solids

Smoke evidence: docs/agent/smoke/adam-chatgpt-gaps-smoke.json
Satisfy ValidatorStatus ('solved') and full ok:true review shape;
remove unused ContactGraphResult import so build:cli typecheck passes.
@w1ne
w1ne merged commit 085c5b2 into develop Sep 24, 2026
15 checks passed
@w1ne
w1ne deleted the feat/design-loop-revision-assist branch September 24, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant