docs: refresh the termlens skill copy for the 0.9 drag signature - #48
Merged
Conversation
The bundled copy described `drag(button, (col, row), (col, row))` and
warned that "the tuple types match and the axes do not" — a real hazard in
the API it was written against, and one termlens designed out. 0.9 takes
five flat arguments:
pub fn drag(&mut self, button: impl Into<MouseChord>,
from_col: u16, from_row: u16, to_col: u16, to_row: u16)
so a transposed `find` result is now a compile error rather than a silent
axis swap. The copy here gave a call shape that does not compile and
cautioned about a footgun that no longer exists.
Taken verbatim from termlens/skills/termlens/SKILL.md, which is the source
of truth and was already correct; verified against the signatures in
termlens 0.9.0 rather than trusted: `find` returns (row, col), while
`click`, `click_with`, `scroll` and `resize` are column-first.
No behaviour change — this file is agent guidance, not code.
Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled copy of the termlens skill described an API that no longer exists.
termlens 0.9 takes five flat arguments:
So the stale text was wrong twice over: it gave a call shape that does not
compile, and it warned about a footgun (
the tuple types match and the axes do not) that the new signature exists to eliminate.Taken verbatim from
termlens/skills/termlens/SKILL.md, the source of truth,which was already correct. Verified against the real 0.9.0 signatures rather
than trusted:
Screen::findreturns(row, col), whileclick,click_with,scrollandresizeare all column-first.Found while installing the skill into oxmera and diffing against the canonical.
All three repositories that bundle it — mossaic, launchbound, reconverge — had
byte-identical stale copies; this is one of three identical PRs.
No behaviour change: this file is agent guidance, not code.