fix: rebuild dist/docs to include callout icon fix#49
Merged
Conversation
PR #48 changed source only (src/utils/renderBlockquote.js, src/styles/font-styles.js) and never rebuilt dist/docs, so the published bundle still referenced the dead vtex-dev-portal-navigation DigitalOcean Space. This rebuilds dist/ and docs/ so consumers (e.g. the devportal git submodule) actually get the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Rebuilds
dist/anddocs/(the committed build output) so the callout-icon fix from #48 is actually present in the published bundle.What problem is this solving?
#48 fixed the callout-icon rendering in source (
src/utils/renderBlockquote.js,src/styles/font-styles.js) but never rebuiltdist//docs/. Consumers like thedevportalgit submodule use the committeddocs/rapidoc-min.jsdirectly, so merging #48 alone had no visible effect — the served bundle still referenced the deadvtex-dev-portal-navigationDigitalOcean Space.Same class of issue as vtexdocs/components#87.
How should this be manually tested?
Load a spec with a description containing
> ℹ️ text,> ⚠️ text, or> ❗ textand confirm the callout renders a colored circle icon (info/warning/danger).Screenshots or example usage
Confirmed
dist/rapidoc-min.js,docs/rapidoc-min.js,dist/rapidoc.js, anddocs/rapidoc.jsno longer contain anydigitaloceanspacesreferences and now include thecallout-iconclass.Types of changes