Rebuilt Bolivia countryData and added a test for the postal code handler function#698
Open
kaio-donadelli wants to merge 5 commits into
Open
Rebuilt Bolivia countryData and added a test for the postal code handler function#698kaio-donadelli wants to merge 5 commits into
kaio-donadelli wants to merge 5 commits into
Conversation
…r the postal code handler function. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
4 tasks
Correct Tarija Avilez OEP codes, make the handler immutable, harden geolocation test helpers, and exclude helpers from Jest discovery. Co-authored-by: Cursor <cursoragent@cursor.com>
🛡️ SDD Check — action requiredI couldn't detect an SDD in this PR. Please check one option below (requires write access to the repo):
|
Lurian
approved these changes
Jul 1, 2026
Extract createPostalCodeFromHierarchyHandler in JavaScript, migrate BOL, COL, CRI, PER, and CHL, and restrict integration tests to Bolivia only. Co-authored-by: Cursor <cursoragent@cursor.com>
fdaciuk
approved these changes
Jul 1, 2026
fdaciuk
left a comment
There was a problem hiding this comment.
Aprovado — a factoria compartilhada e os testes de não-mutação resolvem os pontos mais importantes. Fica só uma sugestão não bloqueante inline.
Search explicitly for two administrative paths whose postal codes differ instead of assuming the first municipality of two provinces always differs. Co-authored-by: Cursor <cursoragent@cursor.com>
Use lodash/get for hierarchy lookup and fail explicitly when alternate hierarchy sample is missing in tests. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Backport of #697 to
4.x: fix missing and incorrect Bolivia postal code and location data using INE 2024 Census sources, and ensure geolocation resolves the correct postal code from the administrative hierarchy.Summary
BOLcountry data from INE 2024createPostalCodeFromHierarchyHandler; migrated BOL, COL, CRI, PER, CHLTypes of changes
Related